lkml.org 
[lkml]   [2023]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC kvmtool 24/31] arm64: Don't try to debug a realm
    Date
    From: Alexandru Elisei <alexandru.elisei@arm.com>

    Don't read the register values for a running realm, because they don't
    reflect the actual hardware state of a realm. And don't try to read realm
    memory, because that will promptly lead to kvmtool being killed.

    Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    ---
    arm/aarch64/kvm-cpu.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/arm/aarch64/kvm-cpu.c b/arm/aarch64/kvm-cpu.c
    index 32fa7609..a29a3413 100644
    --- a/arm/aarch64/kvm-cpu.c
    +++ b/arm/aarch64/kvm-cpu.c
    @@ -250,6 +250,9 @@ void kvm_cpu__show_code(struct kvm_cpu *vcpu)

    reg.addr = (u64)&data;

    + if (vcpu->kvm->cfg.arch.is_realm)
    + return;
    +
    dprintf(debug_fd, "\n*pc:\n");
    reg.id = ARM64_CORE_REG(regs.pc);
    if (ioctl(vcpu->vcpu_fd, KVM_GET_ONE_REG, &reg) < 0)
    @@ -274,6 +277,11 @@ void kvm_cpu__show_registers(struct kvm_cpu *vcpu)
    reg.addr = (u64)&data;
    dprintf(debug_fd, "\n Registers:\n");

    + if (vcpu->kvm->cfg.arch.is_realm) {
    + dprintf(debug_fd, " UNACCESSIBLE\n");
    + return;
    + }
    +
    reg.id = ARM64_CORE_REG(regs.pc);
    if (ioctl(vcpu->vcpu_fd, KVM_GET_ONE_REG, &reg) < 0)
    die("KVM_GET_ONE_REG failed (pc)");
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-03-26 23:58    [W:2.150 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site