Messages in this thread | | | Date | Fri, 27 Jan 2023 07:30:42 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] fs: build the legacy direct I/O code conditionally |
| |
On Thu, Jan 26, 2023 at 09:20:20PM +0000, Al Viro wrote: > On Wed, Jan 25, 2023 at 07:58:39AM +0100, Christoph Hellwig wrote: > > Add a new LEGACY_DIRECT_IO config symbol that is only selected by the > > file systems that still use the legacy blockdev_direct_IO code, so that > > kernels without support for those file systems don't need to build the > > code. > > Looks sane... FWIW, I've got this in the misc pile; doesn't seem to > conflict anything in your series, thankfully...
Yes, this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
If someone had time to convert ocfs2 to iomap we could also kill the entire __blockdev_direct_IO variant.
| |