lkml.org 
[lkml]   [2023]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust
Hi Andy,

On Fri, Jan 27, 2023 at 11:10 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Jan 27, 2023 at 10:52:02AM +0100, Geert Uytterhoeven wrote:
> > On Fri, Jan 27, 2023 at 10:43 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote:
> > > > + * Check if @sup_handle or any of its ancestors or suppliers direct/indirectly
> > > > + * depend on @con. This function can detect multiple cyles between @sup_handle
> > >
> > > A single space is enough.
> >
> > It's very common to write two spaces after a full stop.

See e.g.:

git grep "\. [^ ]

> > When joining two sentences on separate lines in vim using SHIFT-J,
> > vim will make sure there are two spaces.
>
> But is this consistent with all kernel doc comments in the core.c?

Probably there are inconsistencies...
(Aren't there everywhere?)

> I'm fine with either as long as it's consistent.

At least the kerneldoc source will look similar to the PDF output
(LaTeX inserts more space after a full stop automatically ;-).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2023-03-26 23:58    [W:0.069 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site