| Date | Fri, 27 Jan 2023 11:27:06 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 04/11] gpiolib: Clear the gpio_device's fwnode initialized flag before adding |
| |
On Thu, Jan 26, 2023 at 04:11:31PM -0800, Saravana Kannan wrote: > Registering an irqdomain sets the flag for the fwnode. But having the > flag set when a device is added is interpreted by fw_devlink to mean the > device has already been initialized and will never probe. This prevents > fw_devlink from creating device links with the gpio_device as a > supplier. So, clear the flag before adding the device.
...
> + /* > + * If fwnode doesn't belong to another device, it's safe to clear its > + * initialized flag. > + */ > + if (!gdev->dev.fwnode->dev) > + fwnode_dev_initialized(gdev->dev.fwnode, false);
Do not dereference fwnode in struct device. Use dev_fwnode() for that.
struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev);
if (!fwnode->dev) fwnode_dev_initialized(fwnode, false);
+ Blank line.
> ret = gcdev_register(gdev, gpio_devt); > if (ret) > return ret;
-- With Best Regards, Andy Shevchenko
|