Messages in this thread | | | Date | Thu, 26 Jan 2023 12:16:16 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 5/5] gpio: Clean up headers |
| |
On Thu, Jan 26, 2023 at 09:42:32AM +0100, Arnd Bergmann wrote: > On Wed, Jan 25, 2023, at 21:10, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > include/asm-generic/gpio.h | 8 -------- > > include/linux/gpio.h | 9 +++------ > > include/linux/gpio/consumer.h | 14 ++++++++++---- > > include/linux/gpio/driver.h | 34 ++++++++++++++++++++++++---------- > > 4 files changed, 37 insertions(+), 28 deletions(-) > > This change looks fine, but it conflicts with a slightly > broader cleanup that I meant to have already submitted, > folding include/asm-generic/gpio.h into linux/gpio.h and > removing the driver-side interface from that. > > Let me try to dig out my series again, we should be able to > either use my version, or merge parts of this patch into it.
Can you share your patches, so I will rebase mine on top and see what's left?
-- With Best Regards, Andy Shevchenko
| |