Messages in this thread | | | Date | Thu, 26 Jan 2023 10:52:19 +0100 | Subject | Re: [PATCH v10 1/8] iov_iter: Define flags to qualify page extraction. | From | David Hildenbrand <> |
| |
On 26.01.23 10:49, David Howells wrote: > David Hildenbrand <david@redhat.com> wrote: > >> Just a note that the usage of new __bitwise types instead of "unsigned" is >> encouraged for flags. >> >> See rmap_t in include/linux/rmap.h as an example. > > Hmmm... rmap_t really ought to be unsigned int.
Not sure if that particularly matters here in practice, ... anyhow
$ git grep "typedef int" | grep __bitwise | wc -l 27 $ git grep "typedef unsigned" | grep __bitwise | wc -l 23
So chose what you prefer ;)
-- Thanks,
David / dhildenb
| |