Messages in this thread | | | Date | Fri, 27 Jan 2023 00:45:35 +0100 | Subject | Re: [PATCH v11 1/8] iov_iter: Define flags to qualify page extraction. | From | David Hildenbrand <> |
| |
On 26.01.23 22:54, Al Viro wrote: > On Thu, Jan 26, 2023 at 02:16:19PM +0000, David Howells wrote: > >> +typedef unsigned int iov_iter_extraction_t; > >> +/* Flags for iov_iter_get/extract_pages*() */ >> +/* Allow P2PDMA on the extracted pages */ >> +#define ITER_ALLOW_P2PDMA ((__force iov_iter_extraction_t)0x01) > > That __force makes sense only if you make it a bitwise type - > otherwise it's meaningless. IOW, either turn the typedef into > > typedef unsigned int __bitwise iov_iter_extraction_t; > > or lose __force in the cast... >
Well spotted, iov_iter_extraction_t is missing __bitwise.
-- Thanks,
David / dhildenb
| |