Messages in this thread | | | Date | Mon, 23 Jan 2023 09:13:00 +0100 | Subject | Re: [PATCH 11/15] dt-bindings: mtd: Add binding for Ambarella | From | Krzysztof Kozlowski <> |
| |
On 23/01/2023 08:32, Li Chen wrote: > Ambarella SoC contains nand flash controller. > Add compatible for it. > > Signed-off-by: Li Chen <lchen@ambarella.com> > Change-Id: I4108699a0678ba45e5d4347cbd860bc552dd91dd > --- > .../bindings/mtd/ambarella,nand.yaml | 77 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > new file mode 100644 > index 000000000000..7c2e7c2ebc7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/ambarella,nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ambarella NAND Controller > + > +maintainers: > + - Li Chen <lchen@ambarella.com> > + > +properties: > + compatible: > + - const: ambarella,nand > + > + reg: > + minItems: 1 > + maxItems: 1
All your patches are weirder and weirder. Do you see such syntax in any patches before?
Drop minItems.
> + > + interrupts: > + minItems: 1 > + maxItems: 1
Drop both.
> + items: > + - description: fio irq > + > + clocks: > + maxItems: 1 > + description: reference to the clock for the NAND controller > + > + nand-on-flash-bbt:
OK, so this was for sure not tested.
Do not send untested patches.
Best regards, Krzysztof
| |