Messages in this thread | | | Date | Mon, 23 Jan 2023 11:35:33 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] phy: qcom-qmp: Introduce Kconfig symbols for discrete drivers |
| |
On Fri, Jan 13, 2023 at 04:09:10PM -0800, Stephen Boyd wrote: > Introduce a config option for each QMP PHY driver now that the QMP PHY > mega-driver has been split up into different modules. This allows kernel > configurators to limit the binary size of the kernel by only compiling > in the QMP PHY driver that they need, or to split the module up into one > per PHY driver instead of one module for all the QMP PHY drivers.
Nit: The drivers are already built as separate modules even if they can currently only be enabled together.
> Leave the old config QCOM_QMP in place and make it into a menuconfig so > that 'make olddefconfig' continues to work. Furthermore, set the default > of the new Kconfig symbols to be QCOM_QMP so that the transition is > smooth.
Perhaps this should go eventually.
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Johan Hovold <johan+linaro@kernel.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Looks good otherwise:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
| |