lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 04/14] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0
    Hi Kuogee,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on next-20230123]
    [also build test WARNING on linus/master v6.2-rc5]
    [cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.2-rc5 v6.2-rc4 v6.2-rc3]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Kuogee-Hsieh/drm-msm-dp-add-dpcd-read-of-both-dsc-and-fec-capability/20230124-022759
    patch link: https://lore.kernel.org/r/1674498274-6010-5-git-send-email-quic_khsieh%40quicinc.com
    patch subject: [PATCH v1 04/14] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0
    config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230124/202301240836.ik3aytbc-lkp@intel.com/config)
    compiler: sparc64-linux-gcc (GCC) 12.1.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/834f569a141af42cb93424c24e7d146f3b88405b
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Kuogee-Hsieh/drm-msm-dp-add-dpcd-read-of-both-dsc-and-fec-capability/20230124-022759
    git checkout 834f569a141af42cb93424c24e7d146f3b88405b
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/gpu/drm/msm/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    >> drivers/gpu/drm/msm/dp/dp_panel.c:571: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Mapper function which outputs colorimetry to be used for a


    vim +571 drivers/gpu/drm/msm/dp/dp_panel.c

    569
    570 /**
    > 571 * Mapper function which outputs colorimetry to be used for a
    572 * given colorspace value when misc field of MSA is used to
    573 * change the colorimetry. Currently only RGB formats have been
    574 * added. This API will be extended to YUV once its supported on DP.
    575 */
    576 u8 dp_panel_get_misc_colorimetry_val(struct dp_panel *dp_panel)
    577 {
    578 u8 colorimetry;
    579 u32 colorspace;
    580 u32 cc;
    581 struct dp_panel_private *panel;
    582
    583 panel = container_of(dp_panel, struct dp_panel_private, dp_panel);
    584
    585 cc = dp_link_get_colorimetry_config(panel->link);
    586 /*
    587 * If there is a non-zero value then compliance test-case
    588 * is going on, otherwise we can honor the colorspace setting
    589 */
    590 if (cc)
    591 return cc;
    592
    593 colorspace = dp_panel->connector->state->colorspace;
    594 switch (colorspace) {
    595 case DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65:
    596 case DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER:
    597 colorimetry = 0x7;
    598 break;
    599 case DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED:
    600 colorimetry = 0x3;
    601 break;
    602 case DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT:
    603 colorimetry = 0xb;
    604 break;
    605 case DRM_MODE_COLORIMETRY_OPRGB:
    606 colorimetry = 0xc;
    607 break;
    608 default:
    609 colorimetry = 0;
    610 }
    611
    612 return colorimetry;
    613 }
    614

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-26 23:53    [W:7.634 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site