lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 3/5] dt-bindings: iio: correct node names in examples
On Sun, Jan 22, 2023 at 05:01:05PM +0000, Jonathan Cameron wrote:
> On Sat, 21 Jan 2023 19:31:23 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> > On 21/01/2023 18:17, Jonathan Cameron wrote:
> > > On Wed, 18 Jan 2023 19:44:11 +0100
> > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
> > >> examples.
> > >>
> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >> ---
> > >
> > >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > >> index 6c5ad426a016..12f75ddc4a70 100644
> > >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > >> @@ -42,7 +42,7 @@ examples:
> > >> #address-cells = <1>;
> > >> #size-cells = <0>;
> > >>
> > >> - heart_mon@0 {
> > >> + heart-rate@0 {
> > >
> > > These are both heart-rate and pulse oximeters so measure more than just
> > > the rate (oxygen saturation in the blood). Reality is they actually
> > > measure light absorption over time, but you can calculate an estimate
> > > of both rate and oxygen saturation from that.
> > >
> > > I don't really mind simplifying that to heart-rate, but wanted to
> > > call this out for possible discussion.
> >
> > They could be heart-mon. The fix is mostly around the underscore. I
> > don't have any arguments for changing it to heart-rate, thus we can go
> > with whatever you prefer.
> I'm fine with either and as we have a patch with heart-rate that wins
> currently. I'll just let this sit for a little longer than
> normal to see if we get any other responses!

I don't care all that much until we've documented something. Otherwise,
we may be just changing things twice. We have the list in the spec, but
really I'd like that in schema form. We'd also need to figure out how to
use that. There's always going to be odd things which we don't have any
defined name.

For now, I'd just do 's/_/-/'.

Rob

\
 
 \ /
  Last update: 2023-03-26 23:53    [W:0.049 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site