[lkml]   [2023]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] paride/pcd: return earlier when an error happens in pcd_atapi()

On 1/22/23 12:49 PM, Jens Axboe wrote:
> On 1/22/23 8:49 AM, Tom Rix wrote:
>> clang static analysis reports
>> drivers/block/paride/pcd.c:856:36: warning: The left operand of '&'
>> is a garbage value [core.UndefinedBinaryOperatorResult]
>> tocentry->cdte_ctrl = buffer[5] & 0xf;
>> ~~~~~~~~~ ^
> Has this one been compiled? I'm guessing not tested...
> In any case, this code is going away hopefully shortly, so let's not
> bother with changes like this.

Going away soon would be nice, this is an old problem.

I did not bother with a fixes: tag because it was is when the repo was
created in 2005.



 \ /
  Last update: 2023-03-26 23:51    [W:0.080 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site