Messages in this thread |  | | Date | Sun, 22 Jan 2023 15:19:24 +0100 | Subject | Re: [PATCH net-next 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support | From | Krzysztof Kozlowski <> |
| |
On 16/01/2023 11:39, Clément Léger wrote: > Add "renesas,rzn1-gmac" binding documention which is compatible which > "snps,dwmac" compatible driver but uses a custom PCS to communicate > with the phy. > > Signed-off-by: Clément Léger <clement.leger@bootlin.com> > --- > .../bindings/net/renesas,rzn1-gmac.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > new file mode 100644 > index 000000000000..effb9a312832 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas GMAC1 Device Tree Bindings
Drop Device Tree Bindings.
> + > +maintainers: > + - Clément Léger <clement.leger@bootlin.com> > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + required: > + - compatible > + > +allOf: > + - $ref: "snps,dwmac.yaml#"
Drop quotes.
> + > +properties: > + compatible: > + additionalItems: true
No. Drop.
> + maxItems: 3
No.
> + items: > + - enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + contains: > + enum: > + - snps,dwmac
No, please list possibilities
> + > + pcs-handle: > + description: > + phandle pointing to a PCS sub-node compatible with > + renesas,rzn1-miic.yaml# > + $ref: /schemas/types.yaml#/definitions/phandle > + > +required: > + - compatible > + > +unevaluatedProperties: false > +
Best regards, Krzysztof
|  |