Messages in this thread |  | | Date | Sun, 22 Jan 2023 15:16:14 +0100 | Subject | Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type | From | Krzysztof Kozlowski <> |
| |
On 20/01/2023 11:25, Astrid Rost wrote: > Add jack-type: Bitmap value of snd_jack_type to allow combining > card drivers to create a jack for it.
Subject: drop "yaml". We do not filename extensions to subject prefix. Nowhere.
> > Signed-off-by: Astrid Rost <astrid.rost@axis.com> > --- > Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml > index 785930658029..1d949b805f98 100644 > --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml > +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml > @@ -27,6 +27,14 @@ properties: > interrupts: > maxItems: 1 > > + jack-type: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Bitmap value of snd_jack_type to allow combining > + card drivers to create a jack for it. Supported is
Why the device would once support (allow) headphone and once not? Device either always supports them or never...
> + 1 SND_JACK_HEADPHONE > + 2 SND_JACK_MICROPHONE
minimum and maximum
> + default: 3 > + > ti,micbias: > $ref: /schemas/types.yaml#/definitions/uint32 > description: Intended MICBIAS voltage (datasheet section 9.6.7).
Best regards, Krzysztof
|  |