Messages in this thread |  | | Date | Sun, 22 Jan 2023 14:46:21 +0100 | Subject | Re: [PATCH v2 1/3] dt-bindings: sound: Add Renesas IDT821034 codec | From | Krzysztof Kozlowski <> |
| |
On 20/01/2023 10:50, Herve Codina wrote: > The Renesas IDT821034 codec is a quad PCM codec with programmable > gain. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > ---
Thank you for your patch. There is something to discuss/improve.
> + gpio-controller: true > + > +required: > + - compatible > + - reg > + - spi-cpha > + - '#sound-dai-cells' > + - gpio-controller > + - '#gpio-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi0 {
I didn't notice it earlier - this should be just "spi".
With above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
|  |