[lkml]   [2023]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller
On 20/01/2023 17:54, Sean Paul wrote:
> On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 20:30, Mark Yacoub wrote:
>>> From: Sean Paul <>
>>> This patch adds the register ranges required for HDCP key injection and
>> Do not use "This commit/patch".
>> This applies to all your patches. Fix it everywhere.
> My goodness, this is peak bikeshedding. Surely we have better things to do with
> our time?

While I would not enforce this rule if there were no other issues with
the commits, Mark will have to cleanup/rework commits anyway, see other
review comments. Thus removing/slightly rephrasing a commit message
sounds like a minor issue to me.

>>> Signed-off-by: Sean Paul <>
>>> Signed-off-by: Mark Yacoub <>
>>> Link: #v1
>>> Link: #v2
>>> Link: #v3
>>> Link: #v4
>>> Link: #v5
>> Drop the links.
> Why? I've always done this, it seems helpful to me?

I'd say, if you wish to include them, they belong to the cover letter,
not to the per-commit message. Once landed, they will serve no purpose.

With best wishes

 \ /
  Last update: 2023-03-26 23:51    [W:0.211 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site