Messages in this thread |  | | From | Frank Wunderlich <> | Subject | Aw: Re: [BUG] vlan-aware bridge breaks vlan on another port on same gmac | Date | Sat, 21 Jan 2023 15:12:50 +0100 |
| |
Hi
> Gesendet: Samstag, 21. Januar 2023 um 14:35 Uhr > Von: "Vladimir Oltean" <olteanv@gmail.com> > An: "Frank Wunderlich" <frank-w@public-files.de> > Cc: "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Landen Chao" <Landen.Chao@mediatek.com>, "Sean Wang" <sean.wang@mediatek.com>, "DENG Qingfang" <dqfext@gmail.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Daniel Golle" <daniel@makrotopia.org> > Betreff: Re: [BUG] vlan-aware bridge breaks vlan on another port on same gmac > > On Sat, Jan 21, 2023 at 01:32:42PM +0100, Frank Wunderlich wrote: > > so first patch fixes the behaviour on bpi-r3 (mt7531)...but maybe mt7530 need the tagging on cpu-port > > > > > Can you try the second patch instead of the first one? Without digging > > > deeply into mt7530 hardware docs, that's the best chance of making > > > things work without changing how the hardware operates. > > > > second patch works for wan, but vlan on bridge is broken, no packets receiving my laptop (also no untagged ones). > > It's hard for me to understand how applying only patch "tag_mtk only > combine VLAN tag with MTK tag is user port is VLAN aware" can produce > the results you describe... For packets sent to port lan0, nothing > should have been changed by that patch, because dsa_port_is_vlan_filtering(dp) > should return true. > > If you can confirm there isn't any mistake in the testing procedure, > I'll take a look later today at the hardware documentation and try to > figure out why the CPU port is configured the way it is.
ok, booted again the kernel with first patch ("mt7530 don't make the CPU port a VLAN user port") and yes lan0-vlan is broken... seems i need to reboot after each lan/wan test to at least clean arp-cache.
but patch2 ("tag_mtk only combine VLAN tag with MTK tag is user port is VLAN aware") still not works on lanbridge vlan (no packet received on target).
regards Frank
|  |