Messages in this thread | | | Date | Fri, 20 Jan 2023 13:52:49 +0100 | Subject | Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak | From | Vlastimil Babka <> |
| |
On 1/19/23 23:42, Andrew Morton wrote: > On Thu, 19 Jan 2023 11:32:36 +0100 Vlastimil Babka <vbabka@suse.cz> wrote: > >> But to be cleaner I'd also suggest Andrew adds the hunk below. The call >> to stack_depot_init() becomes no-op after this patch so it's not a bug >> to leave it there, but it's just misleading now. >> >> ---8<--- >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c >> index 91dda5c2753a..55dc8b8b0616 100644 >> --- a/mm/kmemleak.c >> +++ b/mm/kmemleak.c >> @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void) >> if (kmemleak_error) >> return; >> >> - stack_depot_init(); >> jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); >> jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000); >> > > I added your signoff to this.
Fine with me, thanks.
> I used not to bother for such minor to-be-folded fixups, but now > Stephen sends me automated nags when his scripts detect this.
Ack, will try to remember that next time.
| |