lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 12/24] powerpc/secvar: Don't print error on ENOENT when reading variables
    Date
    If attempting to read the size or data attributes of a  non-existent
    variable (which will be possible after a later patch to expose the PLPKS
    via the secvar interface), don't spam the kernel log with error messages.
    Only print errors for return codes that aren't ENOENT.

    Reported-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
    Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>

    ---

    v3: New patch
    ---
    arch/powerpc/kernel/secvar-sysfs.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
    index 6dd9b4f6f87c..33d1797851ba 100644
    --- a/arch/powerpc/kernel/secvar-sysfs.c
    +++ b/arch/powerpc/kernel/secvar-sysfs.c
    @@ -43,8 +43,8 @@ static ssize_t size_show(struct kobject *kobj, struct kobj_attribute *attr,

    rc = secvar_ops->get(kobj->name, strlen(kobj->name) + 1, NULL, &dsize);
    if (rc) {
    - pr_err("Error retrieving %s variable size %d\n", kobj->name,
    - rc);
    + if (rc != -ENOENT)
    + pr_err("Error retrieving %s variable size %d\n", kobj->name, rc);
    return rc;
    }

    @@ -61,7 +61,8 @@ static ssize_t data_read(struct file *filep, struct kobject *kobj,

    rc = secvar_ops->get(kobj->name, strlen(kobj->name) + 1, NULL, &dsize);
    if (rc) {
    - pr_err("Error getting %s variable size %d\n", kobj->name, rc);
    + if (rc != -ENOENT)
    + pr_err("Error getting %s variable size %d\n", kobj->name, rc);
    return rc;
    }
    pr_debug("dsize is %llu\n", dsize);
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-26 23:48    [W:4.034 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site