lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] dt-bindings: opp: constrain required-opps
From
On 20/01/2023 05:38, Viresh Kumar wrote:
> On 19-01-23, 14:00, Krzysztof Kozlowski wrote:
>> Be specific how many required-opps are allowed.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> This change is independent, although logically is connected with my
>> dtschema pull:
>> https://github.com/devicetree-org/dt-schema/pull/95
>> ---
>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 1 +
>> Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 3 ++-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> index 47e6f36b7637..9b141a409191 100644
>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> @@ -202,6 +202,7 @@ patternProperties:
>> for the functioning of the current device at the current OPP (where
>> this property is present).
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> + maxItems: 1
>
> I may not under this property very well. What exactly does this line
> say ? Asking as required-properties can have an array of phandles as
> well.
>

It says we can have maximum one item in "required-opps" in "opp" node
and you are right that we could have here more. I'll fix it.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:48    [W:0.079 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site