lkml.org 
[lkml]   [2023]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
From
Hi,

On 23/12/2022 13:32, Krzysztof Kozlowski wrote:
> On 23/12/2022 12:09, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> This is the Ethernet driver for TI AM654 Silicon rev. 2
>> with the ICSSG PRU Sub-system running dual-EMAC firmware.
>>
>
>
> (...)
>
>> +
>> +/* Memory Usage of : DMEM1
>> + *
>> + */
>
> ??? What's this?
>
>> +
>> +/* Memory Usage of : PA_STAT
>> + *
>> + */
>
> Same question.
>
>> +
>> +/*Start of 32 bits PA_STAT counters*/
>
> That's not a Linux coding style. Add spaces and make it readable.

The contents of this file were copied from f/w.

This file needs to be reduced to only the elements that
we really use in the Linux driver and coding style fixed.

cheers,
-roger

\
 
 \ /
  Last update: 2023-03-26 23:24    [W:0.047 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site