lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter()
On Thu, Jan 19, 2023 at 11:34:26AM +0000, David Howells wrote:
> io_uring is a bit problematic in this regard. io_prep_rw() starts the
> initialisation of the kiocb, so io_read() and io_write() can't just
> reinitialise it. OTOH, I'm not sure io_prep_rw() has sufficient information
> to hand.

It could probably be refactored. That being said, I suspect we're
better off deferring the whole iov_iter direction cleanup. It's a bit
ugly right now, but there is nothing urgent. The gup pin work otoh
really is something we need to get down rather sooner than later.

So what about deferring this whole cleanup for now?

\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.098 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site