Messages in this thread | | | Date | Thu, 19 Jan 2023 16:40:53 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v4 1/4] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*() |
| |
On Wed, Nov 23, 2022 at 07:55:44PM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 22, 2022 at 2:35 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > First of all, _ELEMENT_SIZE() repeats existing sizeof_field() macro. > > Second, usage of _ARRAY_ELSIZE_LEN() adds unnecessary indirection > > to the data layout. It's more understandable when the data structure > > is placed explicitly. That said, get rid of those macros by replacing > > them with the existing helper and explicit data structure layout. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > The series in which this patch is included does not apply cleanly for me. > > I guess it depends on the earlier material already in Greg's tree, so > I'm leaving it to Greg.
Andy, did I miss this?
confused,
greg k-h
| |