lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/8] arm64: dts: qcom: sc7280: audioreach: Add sound node
From

On 1/10/2023 4:30 PM, Krzysztof Kozlowski wrote:
Thanks for your time Krzysztof!!!
> On 05/01/2023 14:37, Srinivasa Rao Mandadapu wrote:
>> Add sound node for sc7280 based audioreach platforms.
>>
>> Include audioreach dtsi into crd-rev3 platform specific dts file.
>> Also remove phandle to sound node, as audio routing is same as
>> audioreach specific dtsi file.
>>
> Thank you for your patch. There is something to discuss/improve.
>
>> +#include <dt-bindings/sound/qcom,q6afe.h>
>> +
>> +/{
>> + /* BOARD-SPECIFIC TOP LEVEL NODES */
>> + sound: sound {
>> + compatible = "google,sc7280-herobrine";
>> + model = "SC7280-AUDIOREACH";
>> + adsp-mode;
> There is no such property. Test DTS against your schema, so make
> dtbs_check DT_SCHEMA_FILES=google,sc7280-herobrine
Okay. Will fix it.
>
>> + audio-routing =
>> + "IN1_HPHL", "HPHL_OUT",
>> + "IN2_HPHR", "HPHR_OUT",
>> + "AMIC1", "MIC BIAS1",
>> + "AMIC2", "MIC BIAS2",
>> + "VA DMIC0", "MIC BIAS1",
>> + "VA DMIC1", "MIC BIAS1",
>> + "VA DMIC2", "MIC BIAS3",
>> + "VA DMIC3", "MIC BIAS3",
>> + "TX SWR_ADC0", "ADC1_OUTPUT",
>> + "TX SWR_ADC1", "ADC2_OUTPUT",
>> + "TX SWR_ADC2", "ADC3_OUTPUT",
>> + "TX SWR_DMIC0", "DMIC1_OUTPUT",
>> + "TX SWR_DMIC1", "DMIC2_OUTPUT",
>> + "TX SWR_DMIC2", "DMIC3_OUTPUT",
>> + "TX SWR_DMIC3", "DMIC4_OUTPUT",
>> + "TX SWR_DMIC4", "DMIC5_OUTPUT",
>> + "TX SWR_DMIC5", "DMIC6_OUTPUT",
>> + "TX SWR_DMIC6", "DMIC7_OUTPUT",
>> + "TX SWR_DMIC7", "DMIC8_OUTPUT";
>> +
>> + qcom,msm-mbhc-hphl-swh = <1>;
>> + qcom,msm-mbhc-gnd-swh = <1>;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #sound-dai-cells = <0>;
>> +
>> + dai-link@0 {
>> + link-name = "WCD9385 Playback";
>> + reg = <0>;
>> +
>> + cpu {
>> + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
>> + };
>> + codec {
>> + sound-dai = <&wcd9385 0>, <&swr0 0>, <&lpass_rx_macro 0>;
>> + };
>> + platform {
>> + sound-dai = <&q6apm>;
>> + };
>> + };
>> +
>> + dai-link@1 {
>> + link-name = "WCD9385 Capture";
>> + reg = <1>;
>> +
>> + cpu {
>> + sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
>> + };
>> + codec {
>> + sound-dai = <&wcd9385 1>, <&swr1 0>, <&lpass_tx_macro 0>;
>> + };
>> + platform {
>> + sound-dai = <&q6apm>;
>> + };
>> + };
>> +
>> + dai-link@2 {
>> + link-name = "Amplifier Playback";
>> + reg = <3>;
> Missing dtbs W=1 build.
Okay. Will fix it.
>
>> +
>> + cpu {
>> + sound-dai = <&q6apmbedai SECONDARY_MI2S_RX>;
>> + };
>> +
> Use consistent style. Either blank line or not between the
> cpu/codec/platform nodes.
Okay. will fix it.
>
>> + codec {
>> + sound-dai = <&max98360a>;
>> + };
>> +
>> + platform {
>> + sound-dai = <&q6apm>;
>> + };
>> + };
>> +
>> + dai-link@3 {
>> + link-name = "DMIC";
>> + reg = <4>;
> Same problem, wrong reg.
Okay.
>
>> +
>> + cpu {
>> + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
>> + };
>> +
>> + codec {
>> + sound-dai = <&lpass_va_macro 0>;
>> + };
>> +
>> + platform {
>> + sound-dai = <&q6apm>;
>> + };
>> + };
>> + };
>> +};
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.042 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site