lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] drivers/mfd: simple-mfd-i2c: Add generic compatible
On Thu, 19 Jan 2023, Rob Herring wrote:

> On Fri, Dec 02, 2022 at 06:32:26AM -0500, Jesse Taube wrote:
> > Some devices may want to use this driver without having a specific
> > compatible string. Add a generic compatible string to allow this.
>
> What devices need this?
>
> Is that no specific compatible string at all or just in the kernel?
> Because the former definitely goes against DT requirements. The latter
> enables the former without a schema.
>
> >
> > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> > ---
> > drivers/mfd/simple-mfd-i2c.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > index f4c8fc3ee463..0bda0dd9276e 100644
> > --- a/drivers/mfd/simple-mfd-i2c.c
> > +++ b/drivers/mfd/simple-mfd-i2c.c
> > @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
> > };
> >
> > static const struct of_device_id simple_mfd_i2c_of_match[] = {
> > + { .compatible = "simple-mfd-i2c-generic" },
>
> Simple and generic? There is no such device. Anywhere.
>
> This is also not documented which is how I found it (make
> dt_compatible_check). But this should be reverted or dropped rather than
> documented IMO.

I thought it would be better than having a huge list here.

Devices should *also* be allocated a specific compatible string.

$ git grep simple-mfd -- arch

--
Lee Jones [李琼斯]

\
 
 \ /
  Last update: 2023-03-26 23:48    [W:0.184 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site