Messages in this thread | | | Subject | Re: [PATCH net] net: macb: fix PTP TX timestamp failure due to packet padding | From | patchwork-bot+netdevbpf@kernel ... | Date | Wed, 18 Jan 2023 14:30:16 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>:
On Mon, 16 Jan 2023 15:41:33 -0600 you wrote: > PTP TX timestamp handling was observed to be broken with this driver > when using the raw Layer 2 PTP encapsulation. ptp4l was not receiving > the expected TX timestamp after transmitting a packet, causing it to > enter a failure state. > > The problem appears to be due to the way that the driver pads packets > which are smaller than the Ethernet minimum of 60 bytes. If headroom > space was available in the SKB, this caused the driver to move the data > back to utilize it. However, this appears to cause other data references > in the SKB to become inconsistent. In particular, this caused the > ptp_one_step_sync function to later (in the TX completion path) falsely > detect the packet as a one-step SYNC packet, even when it was not, which > caused the TX timestamp to not be processed when it should be. > > [...]
Here is the summary with links: - [net] net: macb: fix PTP TX timestamp failure due to packet padding https://git.kernel.org/netdev/net/c/7b90f5a665ac
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |