Messages in this thread | | | Date | Wed, 18 Jan 2023 13:43:27 +0100 | Subject | Re: [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings | From | Krzysztof Kozlowski <> |
| |
On 18/01/2023 13:39, Gupta, Nipun wrote: > [AMD Official Use Only - General]
Fix your email client. This is not helping us. What shall I do with it?
> > >
(...)
>>> +properties: >>> + compatible: >>> + const: xlnx,cdxbus-controller >> >> This misses SoC specific compatible. Drop "bus" - redundant. I would >> also say - drop controller - do you see any other devices with such >> compatible naming? Use naming consistent with other devices in the >> kernel. Just open some controllers - SPI, I2C etc. and look there. > > Makes sense. Will use "xlnx,cdx" in compatible.
No, this still misses device specific compatible. You did ignored half of my comment now.
Best regards, Krzysztof
| |