Messages in this thread | | | From | "Gupta, Nipun" <> | Subject | RE: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction | Date | Wed, 18 Jan 2023 10:58:04 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Tuesday, January 17, 2023 7:38 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; > eric.auger@redhat.com; alex.williamson@redhat.com; cohuck@redhat.com; > song.bao.hua@hisilicon.com; mchehab+huawei@kernel.org; maz@kernel.org; > f.fainelli@gmail.com; jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org; > joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com; linux-arm- > kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org; > Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>; git > (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware > interaction > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote: > > +/** Request/Response structure */ > > +#define MCDI_HEADER_OFST 0 > > +#define MCDI_HEADER_CODE_LBN 0 > > +#define MCDI_HEADER_CODE_WIDTH 7 > > +#define MCDI_HEADER_RESYNC_LBN 7 > > +#define MCDI_HEADER_RESYNC_WIDTH 1 > > +#define MCDI_HEADER_DATALEN_LBN 8 > > +#define MCDI_HEADER_DATALEN_WIDTH 8 > > +#define MCDI_HEADER_SEQ_LBN 16 > > +#define MCDI_HEADER_SEQ_WIDTH 4 > > +#define MCDI_HEADER_RSVD_LBN 20 > > +#define MCDI_HEADER_RSVD_WIDTH 1 > > +#define MCDI_HEADER_NOT_EPOCH_LBN 21 > > +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1 > > +#define MCDI_HEADER_ERROR_LBN 22 > > +#define MCDI_HEADER_ERROR_WIDTH 1 > > +#define MCDI_HEADER_RESPONSE_LBN 23 > > +#define MCDI_HEADER_RESPONSE_WIDTH 1 > > +#define MCDI_HEADER_XFLAGS_LBN 24 > > +#define MCDI_HEADER_XFLAGS_WIDTH 8 > > <snip> > > This whole file could use some tabs to align all of the values for the > defines to make it readable. Any chance of doing that?
Yes sure. Will update this.
> > thanks, > > greg k-h
| |