lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node
On Wed, Jan 18, 2023 at 06:08:52PM +0000, Rayyan Ansari wrote:
> Add the XO and Sleep Clock sources to the GCC node.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index 4cba25dad8d6..c261fdfbe116 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -370,6 +370,11 @@ gcc: clock-controller@fc400000 {
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> +
> + clocks = <&xo_board>,

If I read the downstream sources [1] correctly, we're missing XO_CLK_SRC
among the 8974 rpm clocks. But that's what "xo" in &gcc should refer to.

Can you please define this clock and use it instead?

[1] https://source.codeaurora.org/quic/la/kernel/msm/tree/arch/arm/mach-msm/clock-8974.c?h=msm-3.4#n715

Regards,
Bjorn

> + <&sleep_clk>;
> + clock-names = "xo",
> + "sleep_clk";
> };
>
> mmcc: clock-controller@fd8c0000 {
> --
> 2.39.0
>
\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.048 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site