Messages in this thread | | | Date | Wed, 18 Jan 2023 14:22:43 -0800 | Subject | Re: [Intel-wired-lan] [PATCH] ice/ptp: fix the PTP worker retrying indefinitely if the link went down | From | Jacob Keller <> |
| |
On 1/18/2023 2:11 PM, Daniel Vacek wrote: > On Wed, Jan 18, 2023 at 9:59 PM Jacob Keller <jacob.e.keller@intel.com> wrote: >> On 1/18/2023 7:14 AM, Daniel Vacek wrote: >> 1) request tx timestamp >> 2) timestamp occurs >> 3) link goes down while processing > > I was thinking this is the case we got reported. But then again, I'm > not really experienced in this field. >
I think it might be, or at least something similar to this.
I think that can be fixed with the link check you added. I think we actually have a copy of the current link status in the ice_ptp or ice_ptp_tx structure which could be used instead of having to check back to the other structure.
I'm just hoping not to re-introduce bugs related to the hardware interrupt counter that we had which results in preventing all future timestamp interrupts.
> --nX > >> 1) link down >> 2) request tx timestamp rejected >> >> Thanks! >> >> -Jake >
| |