Messages in this thread | | | Date | Wed, 18 Jan 2023 10:15:23 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH] arm64: defconfig: Enable missing configs for mt8192-asurada |
| |
On Tue, Jan 17, 2023 at 03:11:59PM -0500, Nícolas F. R. A. Prado wrote: > On Tue, Jan 17, 2023 at 07:58:54AM -0800, Bjorn Andersson wrote: > > On Thu, Jan 12, 2023 at 10:12:38AM -0500, Nícolas F. R. A. Prado wrote: > > > Enable missing configs in the arm64 defconfig to get all devices probing > > > on mt8192-asurada based machines. > > > > > > The devices enabled are: MediaTek Bluetooth USB controller, MediaTek > > > PCIe Gen3 MAC controller, MT7921E wireless adapter, Elan I2C Trackpad, > > > MediaTek SPI NOR flash controller, Mediatek SPMI Controller, ChromeOS EC > > > regulators, MT6315 PMIC, MediaTek Video Codec, MT8192 sound cards, > > > ChromeOS EC rpmsg communication, all MT8192 clocks. > > > > > > Support for DMA Restricted Pool is also enabled since it is used by the > > > WiFi card on this platform. > > > > > > REGULATOR_CROS_EC is enabled as builtin since it powers the MMC > > > controller for the SD card, making it required for booting on some > > > setups. > > > > I presume this implies that there's no ramdisk to carry these additional > > modules? > > There may or may not be, at the discretion of the user, so enable by default. >
As long as the dependency chain is reasonably short this is okay with me.
> > > > > > > > By enabling the support for all of this platform's devices on the > > > defconfig we make it effortless to test the relevant hardware both by > > > developers as well as CI systems like KernelCI. > > > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > > > > --- > > > > > > arch/arm64/configs/defconfig | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index f3053e7018fe..4e806d8068f6 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > [..] > > > @@ -1092,6 +1104,18 @@ CONFIG_CLK_IMX8QXP=y > > > CONFIG_CLK_IMX8ULP=y > > > CONFIG_CLK_IMX93=y > > > CONFIG_TI_SCI_CLK=y > > > +CONFIG_COMMON_CLK_MT8192_AUDSYS=y > > > +CONFIG_COMMON_CLK_MT8192_CAMSYS=y > > > +CONFIG_COMMON_CLK_MT8192_IMGSYS=y > > > +CONFIG_COMMON_CLK_MT8192_IMP_IIC_WRAP=y > > > +CONFIG_COMMON_CLK_MT8192_IPESYS=y > > > +CONFIG_COMMON_CLK_MT8192_MDPSYS=y > > > +CONFIG_COMMON_CLK_MT8192_MFGCFG=y > > > +CONFIG_COMMON_CLK_MT8192_MMSYS=y > > > +CONFIG_COMMON_CLK_MT8192_MSDC=y > > > +CONFIG_COMMON_CLK_MT8192_SCP_ADSP=y > > > +CONFIG_COMMON_CLK_MT8192_VDECSYS=y > > > +CONFIG_COMMON_CLK_MT8192_VENCSYS=y > > > > Are all these clock drivers needed in order to reach a ramdisk, with > > working uart, where further kernel modules could be loaded? > > No, but currently these configs can't be enabled as modules. So my intention is > to enable all of them as builtin for now so we get the functionality there, and > after the drivers and configs are reworked to allow building as modules (which > should happen shortly after [1] is merged), I'll update the defconfig so that > the non-essential ones for boot are set to =m. >
Sounds good to me.
Thanks, Bjorn
> [1] https://lore.kernel.org/all/20230113110616.111001-1-angelogioacchino.delregno@collabora.com/ > > > > > > CONFIG_COMMON_CLK_QCOM=y > > > CONFIG_QCOM_A53PLL=y > > > CONFIG_QCOM_CLK_APCS_MSM8916=y > > > @@ -1398,6 +1422,7 @@ CONFIG_CRYPTO_DEV_HISI_SEC2=m > > > CONFIG_CRYPTO_DEV_HISI_ZIP=m > > > CONFIG_CRYPTO_DEV_HISI_HPRE=m > > > CONFIG_CRYPTO_DEV_HISI_TRNG=m > > > +CONFIG_DMA_RESTRICTED_POOL=y > > > > As this would alter the behavior of other platforms and devices, could > > we please carry this in a patch of its own to aid bisection? > > Sure. > > Thanks, > Nícolas > > > > > Thanks, > > Bjorn > > > > > CONFIG_CMA_SIZE_MBYTES=32 > > > CONFIG_PRINTK_TIME=y > > > CONFIG_DEBUG_KERNEL=y > > > -- > > > 2.39.0 > > >
| |