Messages in this thread | | | Date | Tue, 17 Jan 2023 07:52:58 -0800 | From | Saurabh Singh Sengar <> | Subject | Re: [PATCH 4/4] dt-bindings: hv: Add dt-bindings for VMBus |
| |
On Tue, Jan 17, 2023 at 04:41:22PM +0100, Krzysztof Kozlowski wrote: > On 17/01/2023 16:13, Saurabh Singh Sengar wrote: > > On Mon, Jan 16, 2023 at 07:55:13PM +0100, Krzysztof Kozlowski wrote: > >> On 16/01/2023 17:48, Saurabh Sengar wrote: > >>> Add dt-bindings for Hyper-V VMBus > >>> > >>> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > >>> --- > >>> .../devicetree/bindings/hv/msft,vmbus.yaml | 34 ++++++++++++++++++++++ > >> > >> Also, there is no "hv" hardware, so that's not correct location. If your > >> bindings describe firmware, this should go to firmware. Otherwise, this > >> does not look like suitable for DT. We do not describe software stuff in DT. > > > > VMBus is a virtual device this is simmilar to virtio. I can rename this folder to vmbus. > > > > Then virtio directory. The directories are per subsystems (hardware > classes).
Apologies if I was not clear, I meant to say this is a device conceptually similar to virtio. But this driver has nothing to do with virtio, we should be creating a new folder for it OR I am fine moving it under bus if that's okay.
> > Best regards, > Krzysztof
| |