| From | David Howells <> | Subject | Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() | Date | Tue, 17 Jan 2023 08:28:24 +0000 |
| |
Christoph Hellwig <hch@infradead.org> wrote:
> I suspect the best is to: > > - rename init_sync_kiocb to init_kiocb > - pass a new argument for the destination
Do you mean the direction rather than the destination?
> to it. I'm not entirely > sure if flags is a good thing, or an explicit READ/WRITE might be > better because it's harder to get wrong, even if a the compiler > might generate worth code for it. > - also use it in the async callers (io_uring, aio, overlayfs, loop, > nvmet, target, cachefs, file backed swap)
David
|