lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call
    On Tue, Jan 17, 2023 at 7:16 AM Michal Hocko <mhocko@suse.com> wrote:
    >
    > On Mon 09-01-23 12:53:12, Suren Baghdasaryan wrote:
    > > Move VMA flag modification (which now implies VMA locking) before
    > > anon_vma_lock_write to match the locking order of page fault handler.
    >
    > Does this changelog assumes per vma locking in the #PF?

    Hmm, you are right. Page fault handlers do not use per-vma locks yet
    but the changelog already talks about that. Maybe I should change it
    to simply:
    ```
    Move VMA flag modification (which now implies VMA locking) before
    vma_adjust_trans_huge() to ensure the modifications are done after VMA
    has been locked.
    ```
    Is that better?

    >
    > --
    > Michal Hocko
    > SUSE Labs

    \
     
     \ /
      Last update: 2023-03-26 23:45    [W:4.112 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site