| From | Thomas Gleixner <> | Subject | Re: [PATCH v4 06/19] irqdomain: Drop revmap mutex | Date | Tue, 17 Jan 2023 22:23:20 +0100 |
| |
On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > The global irq_domain_mutex is now held in all paths that update the > revmap structures so there is no longer any need for the revmap mutex.
This can also go after the 3rd race fix, but ...
> static void irq_domain_clear_mapping(struct irq_domain *domain, > irq_hw_number_t hwirq) > { > + lockdep_assert_held(&irq_domain_mutex);
these lockdep asserts want to be part of the [dis]association race fixes. They are completely unrelated to the removal of the revmap_mutex.
Your race fixes change the locking and you want to ensure that all callers comply right there, no?
Thanks,
tglx
|