lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 00/28] Drivers for gunyah hypervisor
    On 1/10/23 3:47 PM, Elliot Berman wrote:
    >>
    >> I haven't looked at the earlier reviews; perhaps the RFC stuff
    >> was requested.  I'm sure it's useful to see that but it doesn't
    >> seem directly helpful if your goal is to get this code upstream.
    >>
    >
    > Right, the RFC patches were requested. Do you have a recommendation for
    > sharing those later patches? I understand it's best practice not to post
    > too many patches. The logical split was to have 1-20 go in first, and
    > the remaining patches submitted later.

    If they're RFC they should be tagged "RFC".

    I do think it's easier for reviewers if you can divide up the
    code into a few smaller series, so reviewing each (sub-)series
    isn't such an overwhelming thing to consider. I've started
    looking (IN GREAT DETAIL) the RPC core code, and haven't gone
    much past that, so I don't have any guidance about how things
    could be structured. (I do appreciate that the early patches
    were small, and built things up gradually.)

    I personally try to keep my series to closer to 5-10 patches,
    though the maintainer(s) involved need to agree to accept the
    smaller series before the full functionality gets enabled when
    it's all accepted.

    You'll get (lots) more feedback from me on the remaining patches,
    eventually. If you decide to re-spin things soon I'd like to know
    your plan so I can review the latest when it's available.

    -Alex

    \
     
     \ /
      Last update: 2023-03-26 23:44    [W:4.416 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site