[lkml]   [2023]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits
On Mon, Jan 16, 2023 at 09:07:00AM +0800, Kemeng Shi wrote:
> >> Why? I think always having the trace even for the commit case seems
> >> very useful for making the traces useful.
> > I think unplug event more likely means that request going to be sent to driver
> > was plugged and in plug list. And the current code do only trace unplug event
> > when dispatching requests from plug list. If so, would it be better to add
> > a new event to trace commit?
> Hi Christoph, which way do you prefer now? Keep unplug event consistent to
> trace commit of requests from plug list only or trace all commits with
> unplug event. Please let me know and I will consider it in next version.
> Thanks.

To me always having the trace feels more useful, but let's see if Jens
has an opinion on it.

 \ /
  Last update: 2023-03-26 23:43    [W:0.059 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site