Messages in this thread | | | Date | Mon, 16 Jan 2023 11:10:20 +0200 | Subject | Re: [PATCH] ASoC: fsl_sai: initialize is_dsp_mode flag | From | Iuliana Prodan <> |
| |
On 1/16/2023 9:07 AM, Shengjiu Wang wrote: > Initialize is_dsp_mode flag in the beginning of function > fsl_sai_set_dai_fmt_tr(). > > When the DAIFMT is DAIFMT_DSP_B the first time, is_dsp_mode is > true, then the second time DAIFMT is DAIFMT_I2S, is_dsp_mode > still true, which is a wrong state. So need to initialize > is_dsp_mode flag every time. > > Fixes: a3f7dcc9cc03 ("ASoC: fsl-sai: Add SND_SOC_DAIFMT_DSP_A/B support.") > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Thanks,
Iulia
> --- > sound/soc/fsl/fsl_sai.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 1c9be8a5dcb1..355ef29af48c 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -281,6 +281,7 @@ static int fsl_sai_set_dai_fmt_tr(struct snd_soc_dai *cpu_dai, > val_cr4 |= FSL_SAI_CR4_MF; > > sai->is_pdm_mode = false; > + sai->is_dsp_mode = false; > /* DAI mode */ > switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > case SND_SOC_DAIFMT_I2S:
| |