Messages in this thread |  | | Date | Sat, 14 Jan 2023 09:24:03 +0200 | Subject | Re: [PATCH] tools:perf:scripts:python:intel-pt-events del unusedvar | From | Adrian Hunter <> |
| |
On 6/01/23 23:56, Alexander Pantyukhin wrote: > The event_attr is never used later, the var is ok be deleted. > Additional code simplification is to substitute string slice comparison > with "substring" function. This case no need to know the length specific > words. > > Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com> > --- > tools/perf/scripts/python/intel-pt-events.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py > index 08862a2582f4..28d08e2fb7cd 100644 > --- a/tools/perf/scripts/python/intel-pt-events.py > +++ b/tools/perf/scripts/python/intel-pt-events.py > @@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn): > print(start_str, src_str) > > def do_process_event(param_dict): > - event_attr = param_dict["attr"]
Should really be moved to the "Unused fields:" comment section a few lines below.
> sample = param_dict["sample"] > raw_buf = param_dict["raw_buf"] > comm = param_dict["comm"] > @@ -359,13 +358,13 @@ def do_process_event(param_dict): > print(glb_switch_str[cpu]) > del glb_switch_str[cpu] > > - if name[0:12] == "instructions": > + if name.startswith("instructions"): > if glb_src: > print_srccode(comm, param_dict, sample, symbol, dso, True) > else: > print_instructions_start(comm, sample) > print_common_ip(param_dict, sample, symbol, dso) > - elif name[0:8] == "branches": > + elif name.startswith("branches"): > if glb_src: > print_srccode(comm, param_dict, sample, symbol, dso, False) > else:
|  |