Messages in this thread |  | | From | Fedor Pchelkin <> | Subject | Re: [PATCH net] can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate | Date | Sat, 14 Jan 2023 20:35:46 +0300 |
| |
Hello,
On Fri, 10 Sep 2021 14:40:05 +0200, Oleksij Rempel wrote: > Ok, I see, this warning makes sense only if session will actually be > deactivated. > > Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> > > Thank you!
As Ziyang Xuan stated, the patch was not applied to upstream.
Usage of WARN_ON_ONCE in this case is actually discouraged: it erroneusly complains in a valid situation.
So the macro should be removed with the aforementioned patch. If it makes some sense for debugging purposes, WARN_ON_ONCE can be replaced with netdev_warn/netdev_notice but anyway discard of WARN_ON_ONCE.
-- Regards,
Fedor
|  |