Messages in this thread |  | | From | Pietro Borrello <> | Date | Sat, 14 Jan 2023 13:17:48 +0100 | Subject | Re: [PATCH v2] inet: fix fast path in __inet_hash_connect() |
| |
On Fri, 13 Jan 2023 at 13:16, Eric Dumazet <edumazet@google.com> wrote: > 1) Given this path was never really used, we have no coverage. > > 2) Given that we do not check inet_ehash_nolisten() return code here.
It seems there are a bunch of call sites where inet_ehash_nolisten() return code is not checked, thus I didn't think of it to be a problem.
> > I would recommend _not_ adding the Fixes: tag, and target net-next tree > > In fact, I would remove this dead code, and reduce complexity. >
This makes a lot of sense. I can post a v3 patch completely removing the fast path.
However, this patch's v1 was already reviewed by Kuniyuki Iwashima <kuniyu@amazon.com>, v2 is a nit, if posting a v3 I think I should remove the Reviewed-by: since it would completely change the patch, but what is the preferred fix?
Best regards, Pietro
|  |