Messages in this thread | | | From | Eric Dumazet <> | Date | Fri, 13 Jan 2023 14:32:01 +0100 | Subject | Re: [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval |
| |
On Fri, Jan 13, 2023 at 2:26 PM Piergiorgio Beruto <piergiorgio.beruto@gmail.com> wrote: > > Revert a wrong fix that was done during the review process. The > intention was to substitute "if(ret < 0)" with "if(ret)". > Unfortunately, the intended fix did not meet the code. > Besides, after additional review, it was decided that "if(ret < 0)" > was actually the right thing to do. > > Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS") > Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Eric Dumazet <edumazet@google.com>
| |