lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting

> > + regmap_update_bits(rpc->regmap, RPCIF_PHYCNT,
> > + RPCIF_PHYCNT_STRTIM(rpc->info->strtim),
> > + RPCIF_PHYCNT_STRTIM(rpc->info->strtim));
>
> I'm not sure this is guaranteed to work, as using rpc->info->strtim as
> the mask may not clear all bits (e.g. on R-Car M3-W it is 6, not 7), and
> the initial values of the bits are documented to be undefined.

Okay, thanks! I will fix this.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-03-26 23:39    [W:0.036 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site