lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 0/6] x86: Fix suspend vs retbleed=stuff
On Fri, Jan 13, 2023 at 07:39:38AM +0000, Joan Bruguera wrote:
> Hi Peter,
>
> I tried your patches on both QEMU and my two (real) computers where
> s2ram with `retbleed=stuff` was failing and they wake up fine now.

Yay \o/

> However, I think some minor reviews are needed:
>
> (1) I got a build error due to a symbol conflict between the
> `restore_registers` in `arch/x86/include/asm/suspend_64.h` and the
> one in `drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c`.
>
> (I fixed by renaming the one in `hw_gpio.c`, but it's worth
> an `allmodconfig` just in case there's something else)

Urgh, must be my .config for not spotting that, will fix!

> (2) Tracing with QEMU I still see two `sarq $5, %gs:0x1337B33F` before
> `%gs` is restored. Those correspond to the calls from
> `secondary_startup_64` in `arch/x86/kernel/head_64.S` to
> `verify_cpu` and `sev_verify_cbit`.
> Those don't cause a crash but look suspicious, are they correct?
>
> (There are also some `sarq`s in the call to `early_setup_idt` from
> `secondary_startup_64`, but `%gs` is restored immediately before)

OK, I'll have a look, thanks!

\
 
 \ /
  Last update: 2023-03-26 23:39    [W:0.134 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site