Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 13 Jan 2023 10:05:09 +0100 | Subject | Re: [PATCH] PCI: rcar: avoid defines prefixed with CONFIG |
| |
Hi Lukas,
On Fri, Jan 13, 2023 at 9:52 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > Defines prefixed with "CONFIG" should be limited to proper Kconfig options, > that are introduced in a Kconfig file. > > Here, a definition for a bitmask to configure the SEND_ENABLE mode is named > CONFIG_SEND_ENABLE. > > Rename this local definition to CONFIGURE_SEND_ENABLE to avoid defines > prefixed with "CONFIG". > > No functional change. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks for your patch!
> --- a/drivers/pci/controller/pcie-rcar.h > +++ b/drivers/pci/controller/pcie-rcar.h > @@ -11,7 +11,7 @@ > > #define PCIECAR 0x000010 > #define PCIECCTLR 0x000018 > -#define CONFIG_SEND_ENABLE BIT(31) > +#define CONFIGURE_SEND_ENABLE BIT(31)
The R-Car Gen3 rev. 2.30 Hardware User's Manual calls the bit "CCIE".
Hence if I would have written the driver, I would have used
#define PCIECCTLR_CCIE BIT(31) /* Configuration Send Enable */
> #define TYPE0 (0 << 8) > #define TYPE1 BIT(8) > #define PCIECDR 0x000020
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |