lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: serial: option: add Quectel EM05CN modem
On Thu, Jan 12, 2023 at 10:27:39PM -0800, Duke Xin(辛安文) wrote:
> The EM05CN modem has 2 USB configurations that are configurable via the AT
> command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with
> the following interfaces, respectively:
>
> "MBIM" : AT + MBIM + DIAG + NMEA + MODEM
> "RMNET" : AT + DIAG + NMEA + Modem + QMI

Thanks for the update. When sending a new revision of patch, make sure
to include a version number in Subject (e.g. in this case "[PATCH v2]
USB: serial: ...).

Also add short changelog below the --- line (so that it doesn't end up
in the git logs).

You again sent two patches with identical Subject adding different
devices. Please add the variant in parenthesis or similar so that we can
tell them apart (e.g. "EM05CN (SG)").

Can you fix that up in a v3 (for both of these patches)?

> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> ---

Johan

\
 
 \ /
  Last update: 2023-03-26 23:39    [W:0.024 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site