Messages in this thread | | | Date | Fri, 13 Jan 2023 20:43:36 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2 net-next 04/12] net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC) |
| |
On Wed, 11 Jan 2023 18:16:58 +0200 Vladimir Oltean wrote: > +/** > + * enum ethtool_stats_src - source of ethtool statistics > + * @ETHTOOL_STATS_SRC_AGGREGATE: > + * if device supports a MAC merge layer, this retrieves the aggregate > + * statistics of the eMAC and pMAC. Otherwise, it retrieves just the > + * statistics of the single (express) MAC. > + * @ETHTOOL_STATS_SRC_EMAC: > + * if device supports a MM layer, this retrieves the eMAC statistics. > + * Otherwise, it retrieves the statistics of the single (express) MAC. > + * @ETHTOOL_STATS_SRC_PMAC: > + * if device supports a MM layer, this retrieves the pMAC statistics. > + */ > +enum ethtool_stats_src { > + ETHTOOL_STATS_SRC_AGGREGATE, > + ETHTOOL_STATS_SRC_EMAC, > + ETHTOOL_STATS_SRC_PMAC, > +};
Should we somehow call it "MAC stats"?
Right now its named like a generic attribute, but it's not part of the header nest (ETHTOOL_A_HEADER_*).
I'm not sure myself which way is better, but feels like either it should be generic, in the header nest, and parsed by the common code; or named more specifically and stay in the per-cmd attrs.
| |