lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 3/6] net: dcb: add new rewrite table
On Thu, Jan 12, 2023 at 09:15:51PM +0100, Daniel Machon wrote:
> +/* Get protocol value from rewrite entry. */
> +u16 dcb_getrewr(struct net_device *dev, struct dcb_app *app)
^^^

> +{
> + struct dcb_app_type *itr;
> + u8 proto = 0;

Should "proto" be a u16 to match itr->app.protocol and the return type?

> +
> + spin_lock_bh(&dcb_lock);
> + itr = dcb_rewr_lookup(app, dev->ifindex, -1);
> + if (itr)
> + proto = itr->app.protocol;
> + spin_unlock_bh(&dcb_lock);
> +
> + return proto;
> +}
> +EXPORT_SYMBOL(dcb_getrewr);
> +
> + /* Add rewrite entry to the rewrite list. */
> +int dcb_setrewr(struct net_device *dev, struct dcb_app *new)
> +{
> + int err = 0;

No need to initialize this. It only disables static checkers and
triggers a false positive about dead stores.

> +
> + spin_lock_bh(&dcb_lock);
> + /* Search for existing match and abort if found. */
> + if (dcb_rewr_lookup(new, dev->ifindex, new->protocol)) {
> + err = -EEXIST;
> + goto out;
> + }
> +
> + err = dcb_app_add(&dcb_rewr_list, new, dev->ifindex);
> +out:
> + spin_unlock_bh(&dcb_lock);
> +
> + return err;
> +}

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-03-26 23:39    [W:0.070 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site