Messages in this thread | | | Subject | Re: [PATCH net] net: lan966x: add missing fwnode_handle_put() for ports node | From | Alexander H Duyck <> | Date | Fri, 13 Jan 2023 14:39:04 -0800 |
| |
On Thu, 2023-01-12 at 17:13 +0100, Clément Léger wrote: > Since the "ethernet-ports" node is retrieved using > device_get_named_child_node(), it should be release after using it. Add > missing fwnode_handle_put() and move the code that retrieved the node > from device-tree to avoid complicated handling in case of error. > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
You should probably add a fixes tag to this: Fixes: db8bcaad5393 ("net: lan966x: add the basic lan966x driver")
Other than that the patch itself looks good to me.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
| |