Messages in this thread | | | Date | Fri, 13 Jan 2023 11:40:08 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net] rxrpc: Fix wrong error return in rxrpc_connect_call() |
| |
On Wed, 11 Jan 2023 18:07:15 +0000 David Howells wrote: > Fix rxrpc_connect_call() to return -ENOMEM rather than 0 if it fails to > look up a peer. > > This generated a smatch warning: > net/rxrpc/call_object.c:303 rxrpc_connect_call() warn: missing error code 'ret' > > I think this also fixes a syzbot-found bug: > > rxrpc: Assertion failed - 1(0x1) == 11(0xb) is false > ------------[ cut here ]------------ > kernel BUG at net/rxrpc/call_object.c:645! > > where the call being put is in the wrong state - as would be the case if we > failed to clear up correctly after the error in rxrpc_connect_call().
Applied, thanks!
| |